Skip to content

chore(NA): remove mocha junit ci integrations#88129

Merged
mistic merged 8 commits intoelastic:masterfrom
mistic:remove-mocha-tools
Jan 15, 2021
Merged

chore(NA): remove mocha junit ci integrations#88129
mistic merged 8 commits intoelastic:masterfrom
mistic:remove-mocha-tools

Conversation

@mistic
Copy link
Contributor

@mistic mistic commented Jan 13, 2021

That PR closes #85513

It removes mocha junit ci integration completely and the tools around it.

@mistic mistic marked this pull request as ready for review January 14, 2021 17:09
@mistic mistic requested review from a team as code owners January 14, 2021 17:09
@mistic mistic requested a review from tylersmalley January 14, 2021 17:09
@mistic mistic added chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.1 v7.12.0 v8.0.0 labels Jan 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Contributor Author

mistic commented Jan 14, 2021

@elastic/kibana-presentation can I have a quick code owners review here please?

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed all tests from master are running in this PR too

@tylersmalley
Copy link
Member

Can you remove the Mocha portions within docs/developer/contributing/development-unit-tests.asciidoc?

Copy link
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nit's.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB -34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.2KB 60.1KB -34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mistic mistic merged commit 9139ab1 into elastic:master Jan 15, 2021
@mistic
Copy link
Contributor Author

mistic commented Jan 15, 2021

7.x/7.12: 7bdac0b
7.11/7.11.1: 250ed02

mistic added a commit to mistic/kibana that referenced this pull request Jan 15, 2021
* chore(NA): remove mocha junit ci integrations

* chore(NA): remove mocha script from xpack

* chore(NA): single rule exclusion on eslint config for mocha

* chore(NA): remove unused custom mocha integration code from kbn/test

* chore(NA): rewording packages readme

* docs(NA): remoe mocha mention from development-unit-tests
# Conflicts:
#	docs/developer/contributing/development-unit-tests.asciidoc
#	test/scripts/jenkins_unit.sh
mistic added a commit to mistic/kibana that referenced this pull request Jan 15, 2021
* chore(NA): remove mocha junit ci integrations

* chore(NA): remove mocha script from xpack

* chore(NA): single rule exclusion on eslint config for mocha

* chore(NA): remove unused custom mocha integration code from kbn/test

* chore(NA): rewording packages readme

* docs(NA): remoe mocha mention from development-unit-tests
# Conflicts:
#	docs/developer/contributing/development-unit-tests.asciidoc
#	test/scripts/jenkins_unit.sh
mistic added a commit that referenced this pull request Jan 16, 2021
* chore(NA): remove mocha junit ci integrations

* chore(NA): remove mocha script from xpack

* chore(NA): single rule exclusion on eslint config for mocha

* chore(NA): remove unused custom mocha integration code from kbn/test

* chore(NA): rewording packages readme

* docs(NA): remoe mocha mention from development-unit-tests
# Conflicts:
#	docs/developer/contributing/development-unit-tests.asciidoc
#	test/scripts/jenkins_unit.sh
mistic added a commit that referenced this pull request Jan 16, 2021
* chore(NA): remove mocha junit ci integrations

* chore(NA): remove mocha script from xpack

* chore(NA): single rule exclusion on eslint config for mocha

* chore(NA): remove unused custom mocha integration code from kbn/test

* chore(NA): rewording packages readme

* docs(NA): remoe mocha mention from development-unit-tests
# Conflicts:
#	docs/developer/contributing/development-unit-tests.asciidoc
#	test/scripts/jenkins_unit.sh
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 18, 2021
* master: (33 commits)
  [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311)
  [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420)
  Fix log msg (elastic#88370)
  [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600)
  removing kibana-core-ui from codeowners (elastic#88111)
  [Alerting] Migrate Event Log plugin to TS project references (elastic#81557)
  [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413)
  Porting fixes 1 (elastic#88477)
  [APM] Explicitly set environment for cross-service links (elastic#87481)
  chore(NA): remove mocha junit ci integrations (elastic#88129)
  [APM] Only display relevant sections for rum agent in service overview (elastic#88410)
  [Enterprise Search] Automatically mock shared logic files (elastic#88494)
  [APM] Disable Create custom link button on Transaction details page for read-only users
  [Docs] clean-up vega map reference documenation (elastic#88487)
  [Security Solution] Fix Timeline event details layout (elastic#88377)
  Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914)
  [Monitoring] Change cloud messaging on no data page (elastic#88375)
  [Uptime] clear ping state when PingList component in unmounted (elastic#88321)
  [APM] Consistent terminology for latency and throughput (elastic#88452)
  fix copy (elastic#88481)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.1 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Mocha unit test runner

6 participants